Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct type for button, type for prop #10023

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: use correct type for button, type for prop #10023

merged 1 commit into from
Aug 20, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 20, 2024

Fix two warnings from the phishing component

  • [Vue warn]: Invalid prop: type check failed for prop "phishingData". Expected Object, got Array
  • [Vue warn]: Invalid prop: custom validator check failed for prop "type".

@kesselb
fix: use correct type for button, type for prop
25b7595 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb added this to the v4.0.0 milestone Aug 20, 2024
ChristophWurst
ChristophWurst approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good soup

st3iny
st3iny approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, have a 🍪

@ChristophWurst ChristophWurst merged commit 36f3ea6 into main Aug 20, 2024
28 checks passed
@ChristophWurst ChristophWurst deleted the bug/noid/object-to-array-phishing branch August 20, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees
No one assigned
Labels
4. to release bug
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kesselb @ChristophWurst @st3iny @miaulalala